Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 113396: Reapply revision 1949. Stupid error.... (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Reapply revision 1949. Stupid error. Add virtual destructor to jump targets to make compiler happy. Committed: http://code.google.com/p/v8/source/detail?r=1951

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -251 lines) Patch
M src/arm/virtual-frame-arm.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/frame-element.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/jump-target.h View 5 chunks +13 lines, -3 lines 0 comments Download
M src/jump-target.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A + src/jump-target-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/register-allocator.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/register-allocator-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/virtual-frame.h View 1 chunk +1 line, -198 lines 0 comments Download
M src/virtual-frame.cc View 2 chunks +4 lines, -21 lines 0 comments Download
M src/zone.h View 1 chunk +7 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 7 months ago (2009-05-14 12:16:38 UTC) #1
Kasper Lund
11 years, 7 months ago (2009-05-14 12:17:33 UTC) #2
Yes, yes. LGTM.

Powered by Google App Engine
This is Rietveld 408576698