Issue 113337: Rename presubmit.py to presubmit_support.py to reduce confusion and be able t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113337: Rename presubmit.py to presubmit_support.py to reduce confusion and be able t... (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15954

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -718 lines)			Patch
M	gcl.py	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
D	presubmit.py	View	1	1 chunk	+0 lines, -712 lines	0 comments	Download
A +	presubmit_support.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

M-A Ruel

Wait, added files don't appear anymore. I need to fix that first.

11 years, 7 months ago (2009-05-13 13:31:18 UTC) #2

M-A Ruel

On 2009/05/13 13:31:18, M-A wrote: > Wait, added files don't appear anymore. I need to ...

11 years, 7 months ago (2009-05-13 13:35:21 UTC) #3

M-A Ruel

11 years, 7 months ago (2009-05-13 14:35:48 UTC) #5

On 2009/05/13 14:20:34, Jói wrote:
> LGTM

And I fixed issue 11884 so presubmit_support.py is now there.