Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 113305: - Roll DEPS to pick up newer GYP... (Closed)

Created:
11 years, 7 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

- Roll DEPS to pick up newer GYP - Add script for running dump_syms on release builds if breakpad is enabled. - Update the info.plist tweaks to add the breakpad keys if needed - Add a var to check for breakpad support within the chrome.gyp instead of having the knowledge about breakpad being in official builds spread all around. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15948

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 1 comment Download
A build/mac/dump_app_syms View 1 chunk +37 lines, -0 lines 1 comment Download
M build/mac/tweak_app_infoplist View 3 chunks +51 lines, -2 lines 2 comments Download
M chrome/chrome.gyp View 4 chunks +40 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
TVL
11 years, 7 months ago (2009-05-12 21:46:05 UTC) #1
Mark Mentovai
11 years, 7 months ago (2009-05-12 21:54:16 UTC) #2
lg
tm

http://codereview.chromium.org/113305/diff/1/2
File DEPS (right):

http://codereview.chromium.org/113305/diff/1/2#newcode29
Line 29: "http://gyp.googlecode.com/svn/trunk@477",
Note possible conflict (I just reviewed a change that brings this to 476). 
Easily resolved by whoever loses.

http://codereview.chromium.org/113305/diff/1/3
File build/mac/dump_app_syms (right):

http://codereview.chromium.org/113305/diff/1/3#newcode15
Line 15: # Skip out if we're aren't in Release mode, no need for dump_sym on
debug runs.
dump_syms (add s)

http://codereview.chromium.org/113305/diff/1/4
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/113305/diff/1/4#newcode123
Line 123: defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProduct
"${BUILD_BRANDING}_Mac"
break up long lines

http://codereview.chromium.org/113305/diff/1/4#newcode125
Line 125: defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadVersion
"${FULL_VERSION}"
-string this one

Powered by Google App Engine
This is Rietveld 408576698