Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: build/mac/tweak_app_infoplist

Issue 113305: - Roll DEPS to pick up newer GYP... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/mac/tweak_app_infoplist
===================================================================
--- build/mac/tweak_app_infoplist (revision 15857)
+++ build/mac/tweak_app_infoplist (working copy)
@@ -4,6 +4,32 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+set -e
+
+# Pull off the optional args
+INCLUDE_BREAKPAD=0
+OPTERR=0
+while getopts ":b:" an_opt ; do
+ case $an_opt in
+ b)
+ INCLUDE_BREAKPAD=$OPTARG
+ ;;
+ \?)
+ echo "Unknown option $OPTARG"
+ exit 1
+ ;;
+ :)
+ echo "Option $OPTARG missing it's value"
+ exit 1
+ ;;
+ *)
+ echo "Not recognized argument $an_opt"
+ exit 1
+ ;;
+ esac
+done
+shift $(($OPTIND - 1))
+
# Make sure we got the header to write into passed to us
if [ $# -ne 1 ]; then
echo "error: missing branding as an argument" >&2
@@ -26,12 +52,12 @@
# by the time the app target is done, the info.plist is correct.
#
-set -ex
-
TOP="${SRCROOT}/.."
BUILD_BRANDING=$1
SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${BUILD_BRANDING}.app"
+set -x
+
# Figure out what version this build corresponds to. Just use the svn revision
# for now. Warning: my svnversion returns 10495:10552M. But that's ok since
# it is just for reference.
@@ -89,6 +115,29 @@
defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
NSHumanReadableCopyright -string "${COPYRIGHT_STRING}"
+# Add/Remove the breakpad keys
+if [ "${INCLUDE_BREAKPAD}" == "1" ] ; then
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
+ BreakpadURL "https://clients2.google.com/cr/report"
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadReportInterval "3600"
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProduct "${BUILD_BRANDING}_Mac"
Mark Mentovai 2009/05/12 21:54:16 break up long lines
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProductDisplay "${BUILD_BRANDING}"
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadVersion "${FULL_VERSION}"
Mark Mentovai 2009/05/12 21:54:16 -string this one
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSendAndExit "YES"
+ # TODO: remove/update this when we have first launch
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSkipConfirm "YES"
+else
+ # Make sure the keys aren't there, || true to avoid errors if they aren't.
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadURL || true
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadReportInterval || true
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProduct || true
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProductDisplay || true
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadVersion || true
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSendAndExit || true
+ # TODO: remove/update this when we have first launch
+ defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSkipConfirm || true
+fi
+
# Info.plist will work perfectly well in any plist format, but traditionally
# applications use xml1 for this, so convert it back after whatever defaults
# might have done.
« build/mac/dump_app_syms ('K') | « build/mac/dump_app_syms ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698