Issue 113294: Add presubmit checks to look for BUG= and TEST= tags in change list descripti...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113294: Add presubmit checks to look for BUG= and TEST= tags in change list descripti... (Closed)

Created:
11 years, 7 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, Mark Larson

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2). BUG=11287 TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15905

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -3 lines)			Patch
M	presubmit.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	presubmit_canned_checks.py	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	1	1 chunk	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 7 months ago (2009-05-12 20:23:44 UTC) #2

lgtm even though I think it'd be better to have these be warnings.

http://codereview.chromium.org/113294/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/113294/diff/1/2#newcode23
Line 23: return [output_api.PresubmitError(
Shouldn't it be a warning?

Expand Messages | Collapse Messages