Add presubmit checks to look for BUG= and TEST= tags in change list descripti...

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit.py and presubmit_canned_checks.py."""
 
 import os
 import StringIO
 import unittest
@@ skipping 565 matching lines @@
       self.basename = lambda x: x
       self.urllib2 = self.MockUrllib2()
       self.re = presubmit.re
 
     def RightHandSideLines(self):
       for line in self.lines:
         yield (presubmit.AffectedFile('bingo', 'M'), 1, line)
 
   def testMembersChanged(self):
     members = [
-      'CheckChangeHasNoTabs', 'CheckChangeHasQaField',
-      'CheckChangeHasTestedField', 'CheckDoNotSubmit',
+      'CheckChangeHasBugField', 'CheckChangeHasNoTabs',
+      'CheckChangeHasQaField', 'CheckChangeHasTestedField',
+      'CheckChangeHasTestField', 'CheckDoNotSubmit',
       'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
       'CheckLongLines', 'CheckTreeIsOpen',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit_canned_checks, members)
 
+  def testCannedCheckChangeHasBugField(self):
+    change = self.MakeBasicChange('foo',
+                                  'Foo\nBUG=1234')
+    api = presubmit.InputApi(change, 'PRESUBMIT.py')
+    self.failIf(presubmit_canned_checks.CheckChangeHasBugField(
+        api, presubmit.OutputApi))
+
+    change = self.MakeBasicChange('foo',
+                                  'Foo\nNEVERTESTED=did some stuff')
+    api = presubmit.InputApi(change, 'PRESUBMIT.py')
+    self.failUnless(presubmit_canned_checks.CheckChangeHasBugField(
+        api, presubmit.OutputApi))
+
+  def testCannedCheckChangeHasTestField(self):
+    change = self.MakeBasicChange('foo',
+                                  'Foo\nTEST=did some stuff')
+    api = presubmit.InputApi(change, 'PRESUBMIT.py')
+    self.failIf(presubmit_canned_checks.CheckChangeHasTestField(
+        api, presubmit.OutputApi))
+
+    change = self.MakeBasicChange('foo',
+                                  'Foo\nNOTEST=did some stuff')
+    api = presubmit.InputApi(change, 'PRESUBMIT.py')
+    self.failUnless(presubmit_canned_checks.CheckChangeHasTestField(
+        api, presubmit.OutputApi))
+
   def testCannedCheckChangeHasTestedField(self):
     change = self.MakeBasicChange('foo',
                                   'Foo\nTESTED=did some stuff')
     api = presubmit.InputApi(change, 'PRESUBMIT.py')
     self.failIf(presubmit_canned_checks.CheckChangeHasTestedField(
         api, presubmit.OutputApi))
 
     change = self.MakeBasicChange('foo',
                                   'Foo\nNEVERTESTED=did some stuff')
     api = presubmit.InputApi(change, 'PRESUBMIT.py')
@@ skipping 53 matching lines @@
     self.failIf(presubmit_canned_checks.CheckTreeIsOpen(
       self.MockInputApi(), presubmit.OutputApi, url='url_to_open', closed='0'
     ))
     self.failUnless(presubmit_canned_checks.CheckTreeIsOpen(
       self.MockInputApi(), presubmit.OutputApi, url='url_to_closed', closed='0'
     ))
 
 
 if __name__ == '__main__':
   unittest.main()