Issue 113290: Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113290: Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo(). (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15891

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -99 lines)			Patch
M	gcl.py	View	1	6 chunks	+10 lines, -51 lines	0 comments	Download
M	presubmit.py	View		5 chunks	+6 lines, -4 lines	0 comments	Download
M	tests/gcl_unittest.py	View	1	1 chunk	+4 lines, -37 lines	0 comments	Download
M	tests/presubmit_unittest.py	View		5 chunks	+7 lines, -6 lines	0 comments	Download
M	trychange.py	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Jói Sigurðsson

(drive-by...) presubmit.py currently depends on gcl.GetSVNFileInfo and gcl.GetSVNFileProperty (and some other gcl functions) so either ...

11 years, 7 months ago (2009-05-12 20:21:37 UTC) #2

LGTM