trychange.py - Issue 113290: Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trychange.py

Issue 113290: Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Patch Set: fixed presubmit.py and updated unit tests Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: trychange.py

===================================================================

--- trychange.py (revision 15890)

+++ trychange.py (working copy)

@@ -20,6 +20,7 @@

import urllib

import gcl

+import gclient

__version__ = '1.1'

@@ -132,7 +133,7 @@

for file in files:

# Use svn info output instead of os.path.isdir because the latter fails

# when the file is deleted.

- if gcl.GetSVNFileInfo(file).get("Node Kind") == "directory":

+ if gclient.CaptureSVNInfo(file).get("Node Kind") in ("dir", "directory"):

continue

# If the user specified a custom diff command in their svn config file,

# then it'll be used when we do svn diff, which we don't want to happen

« no previous file with comments | « tests/presubmit_unittest.py ('k') | no next file » | no next file with comments »