Issue 11323: Turn ASSERT(!rn.is(ip)) into CHECK so the error can be caught in release mode...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11323: Turn ASSERT(!rn.is(ip)) into CHECK so the error can be caught in release mode... (Closed)

Created:
12 years, 1 month ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Turn ASSERT(!rn.is(ip)) into CHECK so the error can be caught in release mode. It addresses the problem of 'cmp' instruction that has the side-effect that ip register shouldn't be used as rn. Committed: http://code.google.com/p/v8/source/detail?r=810

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/assembler-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 1 month ago (2008-11-20 18:00:54 UTC) #2

LGTM

And it will check this for all behind-your-back uses of ip.

-Ivan

Expand Messages | Collapse Messages