Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 1132003: Hook up HTML5 effectAllowed and dragEffect on Windows. (Closed)

Created:
10 years, 9 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Hook up HTML5 effectAllowed and dragEffect on Windows. This is the chrome side plumbing, but some patches need to land on the WebKit side. BUG=14654 Committed as r42301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -19 lines) Patch
M chrome/browser/tab_contents/web_drop_target_win.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 6 chunks +29 lines, -13 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_drag_win.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
10 years, 9 months ago (2010-03-19 08:59:58 UTC) #1
tony
this time with the right cc address.
10 years, 9 months ago (2010-03-19 09:02:02 UTC) #2
sky
LGTM
10 years, 9 months ago (2010-03-19 15:25:35 UTC) #3
arv (Not doing code reviews)
10 years, 9 months ago (2010-03-19 16:46:11 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698