Hook up HTML5 effectAllowed and dragEffect on Windows.

chrome/browser/tab_contents/web_drop_target_win.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <shlobj.h>
 
 #include "chrome/browser/tab_contents/web_drop_target_win.h"
 
 #include "app/clipboard/clipboard_util_win.h"
 #include "app/os_exchange_data.h"
 #include "app/os_exchange_data_provider_win.h"
 #include "chrome/browser/bookmarks/bookmark_drag_data.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "gfx/point.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/net_util.h"
 #include "webkit/glue/webdropdata.h"
 #include "webkit/glue/window_open_disposition.h"
 
+using WebKit::WebDragOperationsMask;
+using WebKit::WebDragOperationNone;
 using WebKit::WebDragOperationCopy;
+using WebKit::WebDragOperationLink;
 using WebKit::WebDragOperationMove;
-using WebKit::WebDragOperationsMask;
 
 namespace {
 
 // A helper method for getting the preferred drop effect.
 DWORD GetPreferredDropEffect(DWORD effect) {
   if (effect & DROPEFFECT_COPY)
     return DROPEFFECT_COPY;
   if (effect & DROPEFFECT_LINK)
     return DROPEFFECT_LINK;
   if (effect & DROPEFFECT_MOVE)
     return DROPEFFECT_MOVE;
   return DROPEFFECT_NONE;
 }
 
+DWORD GetPreferredDragCursor(WebDragOperationsMask op) {
+  if (op & WebDragOperationCopy)
+    return DROPEFFECT_COPY;
+  if (op & WebDragOperationLink)
+    return DROPEFFECT_LINK;
+  if (op & WebDragOperationMove)
+    return DROPEFFECT_MOVE;
+  return DROPEFFECT_NONE;
+}
+
+WebDragOperationsMask WinDragOpToWebDragOp(DWORD effect) {
+  WebDragOperationsMask op = WebDragOperationNone;
+  if (effect & DROPEFFECT_COPY)
+    op = static_cast<WebDragOperationsMask>(op | WebDragOperationCopy);
+  if (effect & DROPEFFECT_LINK)
+    op = static_cast<WebDragOperationsMask>(op | WebDragOperationLink);
+  if (effect & DROPEFFECT_MOVE)
+    op = static_cast<WebDragOperationsMask>(op | WebDragOperationMove);
+  return op;
+}
+
 }  // anonymous namespace
 
 // InterstitialDropTarget is like a BaseDropTarget implementation that
 // WebDropTarget passes through to if an interstitial is showing.  Rather than
 // passing messages on to the renderer, we just check to see if there's a link
 // in the drop data and handle links as navigations.
 class InterstitialDropTarget {
  public:
   explicit InterstitialDropTarget(TabContents* tab_contents)
       : tab_contents_(tab_contents) {}
@@ skipping 29 matching lines @@
   DISALLOW_EVIL_CONSTRUCTORS(InterstitialDropTarget);
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 // WebDropTarget, public:
 
 WebDropTarget::WebDropTarget(HWND source_hwnd, TabContents* tab_contents)
     : BaseDropTarget(source_hwnd),
       tab_contents_(tab_contents),
       current_rvh_(NULL),
-      is_drop_target_(false),
+      drag_cursor_(WebDragOperationNone),
       interstitial_drop_target_(new InterstitialDropTarget(tab_contents)) {
 }
 
 WebDropTarget::~WebDropTarget() {
 }
 
 DWORD WebDropTarget::OnDragEnter(IDataObject* data_object,
                                  DWORD key_state,
                                  POINT cursor_position,
                                  DWORD effect) {
   current_rvh_ = tab_contents_->render_view_host();
 
   // Don't pass messages to the renderer if an interstitial page is showing
   // because we don't want the interstitial page to navigate.  Instead,
   // pass the messages on to a separate interstitial DropTarget handler.
   if (tab_contents_->showing_interstitial_page())
     return interstitial_drop_target_->OnDragEnter(data_object, effect);
 
   // TODO(tc): PopulateWebDropData can be slow depending on what is in the
   // IDataObject.  Maybe we can do this in a background thread.
   WebDropData drop_data(GetDragIdentity());
   WebDropData::PopulateWebDropData(data_object, &drop_data);
 
   if (drop_data.url.is_empty())
     OSExchangeDataProviderWin::GetPlainTextURL(data_object, &drop_data.url);
 
-  is_drop_target_ = true;
+  drag_cursor_ = WebDragOperationNone;
 
   POINT client_pt = cursor_position;
   ScreenToClient(GetHWND(), &client_pt);
   tab_contents_->render_view_host()->DragTargetDragEnter(drop_data,
       gfx::Point(client_pt.x, client_pt.y),
       gfx::Point(cursor_position.x, cursor_position.y),
-      static_cast<WebDragOperationsMask>(WebDragOperationCopy |
-                                         WebDragOperationMove));
-      // FIXME(snej): Send actual operation
+      WinDragOpToWebDragOp(effect));
 
   // This is non-null if tab_contents_ is showing an ExtensionDOMUI with
   // support for (at the moment experimental) drag and drop extensions.
   if (tab_contents_->GetBookmarkDragDelegate()) {
     OSExchangeData os_exchange_data(new OSExchangeDataProviderWin(data_object));
     BookmarkDragData bookmark_drag_data;
     if (bookmark_drag_data.Read(os_exchange_data))
       tab_contents_->GetBookmarkDragDelegate()->OnDragEnter(bookmark_drag_data);
   }
 
@@ skipping 11 matching lines @@
     OnDragEnter(data_object, key_state, cursor_position, effect);
 
   if (tab_contents_->showing_interstitial_page())
     return interstitial_drop_target_->OnDragOver(data_object, effect);
 
   POINT client_pt = cursor_position;
   ScreenToClient(GetHWND(), &client_pt);
   tab_contents_->render_view_host()->DragTargetDragOver(
       gfx::Point(client_pt.x, client_pt.y),
       gfx::Point(cursor_position.x, cursor_position.y),
-      static_cast<WebDragOperationsMask>(WebDragOperationCopy |
-                                         WebDragOperationMove));
-      // FIXME(snej): Send actual operation
+      WinDragOpToWebDragOp(effect));
 
   if (tab_contents_->GetBookmarkDragDelegate()) {
     OSExchangeData os_exchange_data(new OSExchangeDataProviderWin(data_object));
     BookmarkDragData bookmark_drag_data;
     if (bookmark_drag_data.Read(os_exchange_data))
       tab_contents_->GetBookmarkDragDelegate()->OnDragOver(bookmark_drag_data);
   }
 
-  if (!is_drop_target_)
-    return DROPEFFECT_NONE;
-
-  return GetPreferredDropEffect(effect);
+  return GetPreferredDragCursor(drag_cursor_);
 }
 
 void WebDropTarget::OnDragLeave(IDataObject* data_object) {
   DCHECK(current_rvh_);
   if (current_rvh_ != tab_contents_->render_view_host())
     return;
 
   if (tab_contents_->showing_interstitial_page()) {
     interstitial_drop_target_->OnDragLeave(data_object);
   } else {
@@ skipping 34 matching lines @@
     if (bookmark_drag_data.Read(os_exchange_data))
       tab_contents_->GetBookmarkDragDelegate()->OnDrop(bookmark_drag_data);
   }
 
   current_rvh_ = NULL;
 
   // We lie and always claim that the drop operation didn't happen because we
   // don't want to wait for the renderer to respond.
   return DROPEFFECT_NONE;
 }