Issue 11318: Beginnings of a new InfoBar system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11318: Beginnings of a new InfoBar system. (Closed)

Created:
12 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Beginnings of a new InfoBar system. This implements AlertInfoBar and InfoBarContainer. It also makes the crashed plugin/js oom infobars use this new system. Design Doc: http://dev.chromium.org/developers/design-documents/info-barshttp://crbug.com/4620 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5856

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+988 lines, -24 lines)			Patch
M	chrome/browser/browser.vcproj	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/browser/infobar_delegate.h	View	1 2 3	1 chunk	+122 lines, -0 lines	0 comments	Download
A	chrome/browser/infobar_delegate.cc	View	2 3	1 chunk	+54 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents.h	View	1 2 3	6 chunks	+31 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents.cc	View	1 2 3	4 chunks	+77 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_views.vcproj	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 2	6 chunks	+26 lines, -9 lines	0 comments	Download
A	chrome/browser/views/infobars/infobar_container.h	View	1 2	1 chunk	+73 lines, -0 lines	0 comments	Download
A	chrome/browser/views/infobars/infobar_container.cc	View	1 2	1 chunk	+131 lines, -0 lines	0 comments	Download
A	chrome/browser/views/infobars/infobars.h	View	1 2 3	1 chunk	+138 lines, -0 lines	0 comments	Download
A	chrome/browser/views/infobars/infobars.cc	View	1 2 3	1 chunk	+291 lines, -0 lines	0 comments	Download
M	chrome/browser/web_contents.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/web_contents.cc	View	2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/notification_types.h	View		1 chunk	+12 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Glen Murphy

12 years, 1 month ago (2008-11-21 20:56:00 UTC) #3

OK.

I mean, it was hideous before. My mind is still overcompensating for such
horrendous hyphenation depletion.