Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5611)

Unified Diff: chrome/browser/web_contents.cc

Issue 11318: Beginnings of a new InfoBar system. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_contents.h ('k') | chrome/common/notification_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_contents.cc
===================================================================
--- chrome/browser/web_contents.cc (revision 5723)
+++ chrome/browser/web_contents.cc (working copy)
@@ -1338,13 +1338,13 @@
if (!product_name.empty())
plugin_name = product_name;
}
- view_->DisplayErrorInInfoBar(
- l10n_util::GetStringF(IDS_PLUGIN_CRASHED_PROMPT, plugin_name));
+ AddInfoBar(new SimpleAlertInfoBarDelegate(
+ l10n_util::GetStringF(IDS_PLUGIN_CRASHED_PROMPT, plugin_name), NULL));
}
void WebContents::OnJSOutOfMemory() {
- view_->DisplayErrorInInfoBar(
- l10n_util::GetString(IDS_JS_OUT_OF_MEMORY_PROMPT));
+ AddInfoBar(new SimpleAlertInfoBarDelegate(
+ l10n_util::GetString(IDS_JS_OUT_OF_MEMORY_PROMPT), NULL));
}
bool WebContents::CanBlur() const {
@@ -1477,7 +1477,7 @@
break;
}
default: {
- NOTREACHED();
+ TabContents::Observe(type, source, details);
break;
}
}
« no previous file with comments | « chrome/browser/web_contents.h ('k') | chrome/common/notification_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698