Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 113161: Linux: really hides the tab close button when it should not be painted. (Closed)

Created:
11 years, 7 months ago by Vincent Zanotti
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: really hides the tab close button when it should not be painted.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/gtk/tabs/tab_gtk.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vincent Zanotti
11 years, 7 months ago (2009-05-08 21:59:44 UTC) #1
James Hawkins
http://codereview.chromium.org/113161/diff/3/4 File chrome/browser/gtk/tabs/tab_gtk.cc (right): http://codereview.chromium.org/113161/diff/3/4#newcode234 Line 234: if (bounds.width() > 0 && bounds.height() > 0) ...
11 years, 7 months ago (2009-05-14 17:19:21 UTC) #2
Vincent Zanotti
http://codereview.chromium.org/113161/diff/3/4 File chrome/browser/gtk/tabs/tab_gtk.cc (right): http://codereview.chromium.org/113161/diff/3/4#newcode234 Line 234: if (bounds.width() > 0 && bounds.height() > 0) ...
11 years, 7 months ago (2009-05-14 19:05:23 UTC) #3
James Hawkins
On 2009/05/14 19:05:23, Vincent Zanotti wrote: > http://codereview.chromium.org/113161/diff/3/4 > File chrome/browser/gtk/tabs/tab_gtk.cc (right): > > http://codereview.chromium.org/113161/diff/3/4#newcode234 ...
11 years, 7 months ago (2009-05-18 21:00:09 UTC) #4
James Hawkins
11 years, 7 months ago (2009-05-18 21:31:22 UTC) #5
On 2009/05/18 21:00:09, James Hawkins wrote:
> On 2009/05/14 19:05:23, Vincent Zanotti wrote:
> > http://codereview.chromium.org/113161/diff/3/4
> > File chrome/browser/gtk/tabs/tab_gtk.cc (right):
> > 
> > http://codereview.chromium.org/113161/diff/3/4#newcode234
> > Line 234: if (bounds.width() > 0 && bounds.height() > 0) {
> > On 2009/05/14 17:19:21, James Hawkins wrote:
> > > Should be (!bounds.IsEmpty()).
> > 
> > Done.
> 
> LGTM. Will commit.

http://codereview.chromium.org/113551

Powered by Google App Engine
This is Rietveld 408576698