Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3348)

Unified Diff: chrome/browser/gtk/tabs/tab_gtk.cc

Issue 113161: Linux: really hides the tab close button when it should not be painted. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/tabs/tab_gtk.cc
===================================================================
--- chrome/browser/gtk/tabs/tab_gtk.cc (revision 16068)
+++ chrome/browser/gtk/tabs/tab_gtk.cc (working copy)
@@ -231,8 +231,13 @@
}
void TabGtk::CloseButtonResized(const gfx::Rect& bounds) {
- gtk_fixed_move(GTK_FIXED(TabRendererGtk::widget()),
- close_button_.get()->widget(), bounds.x(), bounds.y());
+ if (!bounds.IsEmpty()) {
+ gtk_fixed_move(GTK_FIXED(TabRendererGtk::widget()),
+ close_button_.get()->widget(), bounds.x(), bounds.y());
+ gtk_widget_show(close_button_.get()->widget());
+ } else {
+ gtk_widget_hide(close_button_.get()->widget());
+ }
}
void TabGtk::Paint(GdkEventExpose* event) {
@@ -270,7 +275,6 @@
G_CALLBACK(OnCloseButtonClicked), this);
GTK_WIDGET_UNSET_FLAGS(button->widget(), GTK_CAN_FOCUS);
gtk_fixed_put(GTK_FIXED(TabRendererGtk::widget()), button->widget(), 0, 0);
- gtk_widget_show(button->widget());
return button;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698