Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: webkit/compositor_bindings/web_transformation_matrix_unittest.cc

Issue 11316043: Implement unit tests and temporary MathUtil wrappers for transform functionality (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: patch for landing Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/math_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/compositor_bindings/web_transformation_matrix_unittest.cc
diff --git a/webkit/compositor_bindings/web_transformation_matrix_unittest.cc b/webkit/compositor_bindings/web_transformation_matrix_unittest.cc
index fa6ae8eb28b18b7425aa771c9fac9ad22448f1e7..d3df23c466a67481ffcae2fc940c6b2794a63299 100644
--- a/webkit/compositor_bindings/web_transformation_matrix_unittest.cc
+++ b/webkit/compositor_bindings/web_transformation_matrix_unittest.cc
@@ -31,7 +31,7 @@
EXPECT_FLOAT_EQ((a), (matrix).m14()); \
EXPECT_FLOAT_EQ((b), (matrix).m24()); \
EXPECT_FLOAT_EQ((c), (matrix).m34()); \
- EXPECT_FLOAT_EQ((d), (matrix).m44()); \
+ EXPECT_FLOAT_EQ((d), (matrix).m44());
// Checking float values for equality close to zero is not robust using EXPECT_FLOAT_EQ
// (see gtest documentation). So, to verify rotation matrices, we must use a looser
@@ -632,7 +632,6 @@ TEST(WebTransformationMatrixTest, verifyRotateAxisAngle3dForArbitraryAxis)
EXPECT_ROW4_EQ(0, 0, 0, 1, A);
}
-// Test failing as of webkit 132872:132896. http://crbug.com/158553
TEST(WebTransformationMatrixTest, verifyRotateAxisAngle3dForDegenerateAxis)
{
// Check rotation about a degenerate zero vector.
« no previous file with comments | « cc/math_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698