chrome/common/extensions/docs/server2/handler.py - Issue 11315018: Extensions Docs Server: Generalize $ref's to work for any schema node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/handler.py

Issue 11315018: Extensions Docs Server: Generalize $ref's to work for any schema node (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/handler.py

diff --git a/chrome/common/extensions/docs/server2/handler.py b/chrome/common/extensions/docs/server2/handler.py

index a4319acfa701f4a4ccc559fbbe6d53091bd257d7..41434a4038f6b6b228a1f2bfbe16ac0e580c8417 100644

--- a/chrome/common/extensions/docs/server2/handler.py

+++ b/chrome/common/extensions/docs/server2/handler.py

@@ -131,17 +131,19 @@ def _GetInstanceForBranch(channel_name, local_path):

intro_data_source_factory = IntroDataSource.Factory(

cache_factory,

[INTRO_PATH, ARTICLE_PATH])

+ api_data_source_factory = APIDataSource.Factory(

+ cache_factory,

+ API_PATH,

+ api_list_data_source_factory.Create())

not at google - send to devlin 2012/11/02 17:26:48 Looks suspicious. Why isn't APIDataSource.Factory

cduvall 2012/11/03 01:30:05 Done.

samples_data_source_factory = SamplesDataSource.Factory(

channel_name,

file_system,

GITHUB_FILE_SYSTEM,

cache_factory,

GITHUB_COMPILED_FILE_SYSTEM,

+ api_data_source_factory,

api_list_data_source_factory,

EXAMPLES_PATH)

- api_data_source_factory = APIDataSource.Factory(cache_factory,

- API_PATH,

- samples_data_source_factory)

template_data_source_factory = TemplateDataSource.Factory(

channel_name,

api_data_source_factory,