Extensions Docs Server: Generalize $ref's to work for any schema node

chrome/common/extensions/docs/server2/handler.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 from StringIO import StringIO
 import sys
 
 from appengine_wrappers import webapp
@@ skipping 113 matching lines @@
     file_system = _CreateMemcacheFileSystem(branch, branch_memcache)
 
   cache_factory = CompiledFileSystem.Factory(file_system, branch_memcache)
   api_list_data_source_factory = APIListDataSource.Factory(cache_factory,
                                                            file_system,
                                                            API_PATH,
                                                            PUBLIC_TEMPLATE_PATH)
   intro_data_source_factory = IntroDataSource.Factory(
       cache_factory,
       [INTRO_PATH, ARTICLE_PATH])
+  api_data_source_factory = APIDataSource.Factory(
+      cache_factory,
+      API_PATH,
+      api_list_data_source_factory.Create())

[not at google - send to devlin, 2012/11/02 17:26:48]

Looks suspicious. Why isn't APIDataSource.Factory creating this in its Create
call?

[cduvall, 2012/11/03 01:30:05]

Done.

   samples_data_source_factory = SamplesDataSource.Factory(
       channel_name,
       file_system,
       GITHUB_FILE_SYSTEM,
       cache_factory,
       GITHUB_COMPILED_FILE_SYSTEM,
+      api_data_source_factory,
       api_list_data_source_factory,
       EXAMPLES_PATH)
-  api_data_source_factory = APIDataSource.Factory(cache_factory,
-                                                  API_PATH,
-                                                  samples_data_source_factory)
   template_data_source_factory = TemplateDataSource.Factory(
       channel_name,
       api_data_source_factory,
       api_list_data_source_factory,
       intro_data_source_factory,
       samples_data_source_factory,
       KNOWN_ISSUES_DATA_SOURCE,
       cache_factory,
       PUBLIC_TEMPLATE_PATH,
       PRIVATE_TEMPLATE_PATH)
@@ skipping 189 matching lines @@
 
     # Redirect paths like "directory" to "directory/". This is so relative
     # file paths will know to treat this as a directory.
     if os.path.splitext(path)[1] == '' and path[-1] != '/':
       self.redirect(path + '/')
       return
 
     path = path.strip('/')
     if not self._RedirectFromCodeDotGoogleDotCom(path):
       self._HandleGet(path)