ppapi/proxy/gamepad_resource.cc - Issue 11312017: Avoid leaking SerializedHandles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/gamepad_resource.cc

Issue 11312017: Avoid leaking SerializedHandles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/gamepad_resource.cc

diff --git a/ppapi/proxy/gamepad_resource.cc b/ppapi/proxy/gamepad_resource.cc

index 3055513c5c052405193087854d61e7dc47980d85..8a4943767cc30b9fff1c26141050a8a868dc0cad 100644

--- a/ppapi/proxy/gamepad_resource.cc

+++ b/ppapi/proxy/gamepad_resource.cc

@@ -98,8 +98,8 @@ void GamepadResource::Sample(PP_GamepadsSampleData* data) {

void GamepadResource::OnPluginMsgSendMemory(

const ResourceMessageReplyParams& params) {

// On failure, the handle will be null and the CHECK below will be tripped.

- base::SharedMemoryHandle handle;

- params.GetSharedMemoryHandleAtIndex(0, &handle);

+ base::SharedMemoryHandle handle = base::SharedMemory::NULLHandle();

+ params.TakeSharedMemoryHandleAtIndex(0, &handle);

shared_memory_.reset(new base::SharedMemory(handle, true));

CHECK(shared_memory_->Map(sizeof(ContentGamepadHardwareBuffer)));