content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc - Issue 11312017: Avoid leaking SerializedHandles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

Issue 11312017: Avoid leaking SerializedHandles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

diff --git a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

index 23c90efca9e2a46de2d3de10c97a97f8713993fd..da4e4486b0b4ce4b000fd0afe37adee09f81ed38 100644

--- a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

+++ b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

@@ -178,7 +178,7 @@ TEST_F(PepperGamepadHostTest, WaitForReply) {

// Extract the shared memory handle.

base::SharedMemoryHandle reply_handle;

- EXPECT_TRUE(reply_params.GetSharedMemoryHandleAtIndex(0, &reply_handle));

+ EXPECT_TRUE(reply_params.TakeSharedMemoryHandleAtIndex(0, &reply_handle));

// Validate the shared memory.

base::SharedMemory shared_memory(reply_handle, true);

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_gamepad_host.cc ('k') | ppapi/proxy/gamepad_resource.cc » ('j') | no next file with comments »