X64: Changed TickSample to hold pointer-sized values for registers.

src/log.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1064 matching lines @@
   DeleteArray(parameter_string);
   msg.WriteToLogFile();
 #endif
 }
 
 
 #ifdef ENABLE_LOGGING_AND_PROFILING
 void Logger::TickEvent(TickSample* sample, bool overflow) {
   if (!Log::is_enabled() || !FLAG_prof) return;
   LogMessageBuilder msg;
-  msg.Append("tick,0x%x,0x%x,%d", sample->pc, sample->sp,
+  msg.Append("tick,0x%p,0x%p,%d", sample->pc, sample->sp,

[Dean McNamee, 2009/05/07 08:34:08]

I realize this is our own StringStream, but just FYI that %p is different
between Windows and Linux.

[Lasse Reichstein, 2009/05/07 09:06:01]

Yes, it needs to be changed. Will do that in another changelist and use the
change here as well.

              static_cast<int>(sample->state));
   if (overflow) {
     msg.Append(",overflow");
   }
   for (int i = 0; i < sample->frames_count; ++i) {
-    msg.Append(",0x%x", reinterpret_cast<uint32_t>(sample->stack[i]));
+    msg.Append(",0x%p", reinterpret_cast<uint32_t>(sample->stack[i]));

[Dean McNamee, 2009/05/07 08:34:08]

why are you usin %p for a non-pointer?

[Lasse Reichstein, 2009/05/07 09:06:01]

Because I forgot to remove the cast. Good catch.

   }
   msg.Append('\n');
   msg.WriteToLogFile();
 }
 
 
 bool Logger::IsProfilerPaused() {
   return profiler_->paused();
 }
 
@@ skipping 220 matching lines @@
     } else if (previous_->state_ == EXTERNAL) {
       // We are leaving V8.
       Heap::Protect();
     }
   }
 #endif
 }
 #endif
 
 } }  // namespace v8::internal