Extract arguments reconstruction logic out of GetCommandLineString() into GetArgumentsString().

base/command_line.h

Index: base/command_line.h
diff --git a/base/command_line.h b/base/command_line.h
index 37cc71babb48228db59a3ff7f80ba425f31ef634..7d8627fa8417f33c77cc22c88e706ef821d78b50 100644
--- a/base/command_line.h
+++ b/base/command_line.h
@@ -79,9 +79,15 @@ class BASE_EXPORT CommandLine {
   void InitFromArgv(const StringVector& argv);
 
   // Constructs and returns the represented command line string.
-  // CAUTION! This should be avoided because quoting behavior is unclear.
+  // CAUTION! This should be avoided on POSIX because quoting behavior is

[gab, 2012/10/26 18:57:59]

This CAUTION message was inserted a whillleee back
(http://src.chromium.org/viewvc/chrome/trunk/src/base/command_line.cc?r1=76339...);
back when command_line_string was still a simple getter. I think it's ok now for
OS_WIN; not sure for POSIX, so I'll leave the warning for POSIX, but we use this
in production on Windows... so it better work...!

[robertshield, 2012/10/29 02:04:43]

I believe the comment is still valid for POSIX systems, or at least no one who
knows about POSIX command line quoting has come along to invalidate it :)

+  // unclear.
   StringType GetCommandLineString() const;
 
+  // Constructs and returns the represented arguments string.
+  // CAUTION! This should be avoided on POSIX because quoting behavior is
+  // unclear.
+  StringType GetArgumentsString() const;
+
   // Returns the original command line string as a vector of strings.
   const StringVector& argv() const { return argv_; }