Extract arguments reconstruction logic out of GetCommandLineString() into GetArgumentsString().

base/command_line.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class works with command lines: building and parsing.
 // Arguments with prefixes ('--', '-', and on Windows, '/') are switches.
 // Switches will precede all other arguments without switch prefixes.
 // Switches can optionally have values, delimited by '=', e.g., "-switch=value".
 // An argument of "--" will terminate switch parsing during initialization,
 // interpreting subsequent tokens as non-switch arguments, regardless of prefix.
@@ skipping 61 matching lines @@
 
 #if defined(OS_WIN)
   static CommandLine FromString(const std::wstring& command_line);
 #endif
 
   // Initialize from an argv vector.
   void InitFromArgv(int argc, const CharType* const* argv);
   void InitFromArgv(const StringVector& argv);
 
   // Constructs and returns the represented command line string.
-  // CAUTION! This should be avoided because quoting behavior is unclear.
+  // CAUTION! This should be avoided on POSIX because quoting behavior is

[gab, 2012/10/26 18:57:59]

This CAUTION message was inserted a whillleee back
(http://src.chromium.org/viewvc/chrome/trunk/src/base/command_line.cc?r1=76339...);
back when command_line_string was still a simple getter. I think it's ok now for
OS_WIN; not sure for POSIX, so I'll leave the warning for POSIX, but we use this
in production on Windows... so it better work...!

[robertshield, 2012/10/29 02:04:43]

I believe the comment is still valid for POSIX systems, or at least no one who
knows about POSIX command line quoting has come along to invalidate it :)

+  // unclear.
   StringType GetCommandLineString() const;
 
+  // Constructs and returns the represented arguments string.
+  // CAUTION! This should be avoided on POSIX because quoting behavior is
+  // unclear.
+  StringType GetArgumentsString() const;
+
   // Returns the original command line string as a vector of strings.
   const StringVector& argv() const { return argv_; }
 
   // Get and Set the program part of the command line string (the first item).
   FilePath GetProgram() const;
   void SetProgram(const FilePath& program);
 
   // Returns true if this command line contains the given switch.
   // (Switch names are case-insensitive).
   bool HasSwitch(const std::string& switch_string) const;
@@ skipping 62 matching lines @@
   StringVector argv_;
 
   // Parsed-out switch keys and values.
   SwitchMap switches_;
 
   // The index after the program and switches, any arguments start here.
   size_t begin_args_;
 };
 
 #endif  // BASE_COMMAND_LINE_H_