Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1130005: Fix bug inside recordRootFsSize (Closed)

Created:
10 years, 9 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

It worked when all mod for test script works inside chroot. But not anymore since "df /" now report the host disk space, not the rootfs.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/scripts/mod_for_test_scripts/000recordRootFsSize View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
ericli
10 years, 9 months ago (2010-03-21 19:45:43 UTC) #1
kmixter1
LGTM Thanks for fixing... http://codereview.chromium.org/1130005/diff/1/2 File src/scripts/mod_for_test_scripts/000recordRootFsSize (right): http://codereview.chromium.org/1130005/diff/1/2#newcode16 src/scripts/mod_for_test_scripts/000recordRootFsSize:16: df -B1 -P 2>/dev/null | ...
10 years, 9 months ago (2010-03-22 16:12:53 UTC) #2
ericli
I still need either a grep or tail after the df command any way, so ...
10 years, 9 months ago (2010-03-22 16:16:35 UTC) #3
sosa
This is still open. Did you mean to close it?
10 years, 8 months ago (2010-04-01 16:39:43 UTC) #4
ericli
10 years, 8 months ago (2010-04-01 16:54:42 UTC) #5
This change list had been pushed long time ago. I am closing it for now.

On 2010/04/01 16:39:43, sosa wrote:
> This is still open.  Did you mean to close it?

Powered by Google App Engine
This is Rietveld 408576698