Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: lib/compiler/implementation/elements/elements.dart

Issue 11273034: Make unmatched static call a runtime error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix a bug. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/elements/elements.dart
diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart
index 86e6bbd224652a21a863d09e495ee43afaa29423..783454454f1389b540c5ea2e39a5b88f6cab5471 100644
--- a/lib/compiler/implementation/elements/elements.dart
+++ b/lib/compiler/implementation/elements/elements.dart
@@ -148,6 +148,7 @@ class Element implements Spannable {
metadata = metadata.prepend(annotation);
}
+ bool hasSignature() => isFunction() || isConstructor();
ahe 2012/10/25 14:07:27 Let's try to add documentation comments to these m
karlklose 2012/10/26 11:08:48 Done.
bool isFunction() => identical(kind, ElementKind.FUNCTION);
bool isConstructor() => isFactoryConstructor() || isGenerativeConstructor();
bool isClosure() => false;
@@ -1652,6 +1653,7 @@ abstract class ClassElement extends ScopeContainerElement
class Elements {
static bool isUnresolved(Element e) => e == null || e.isErroneous();
static bool isErroneousElement(Element e) => e != null && e.isErroneous();
+ static bool isValid(Element e) => !isUnresolved(e);
ahe 2012/10/25 14:07:27 A documentation comment would also be great here.
karlklose 2012/10/26 11:08:48 Done.
static bool isLocal(Element element) {
return !Elements.isUnresolved(element)
« no previous file with comments | « no previous file | lib/compiler/implementation/lib/js_helper.dart » ('j') | lib/compiler/implementation/resolution/members.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698