Make unmatched static call a runtime error.

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements;
 
 import 'dart:uri';
 
 // TODO(ahe): Rename prefix to 'api' when VM bug is fixed.
 import '../../compiler.dart' as api_e;
@@ skipping 130 matching lines @@
   DartType computeType(Compiler compiler) {
     compiler.internalError("$this.computeType.", token: position());
   }
 
   void addMetadata(MetadataAnnotation annotation) {
     assert(annotation.annotatedElement == null);
     annotation.annotatedElement = this;
     metadata = metadata.prepend(annotation);
   }
 
+  bool hasSignature() => isFunction() || isConstructor();

[ahe, 2012/10/25 14:07:27]

Let's try to add documentation comments to these methods. Starting with this one
:-)

[karlklose, 2012/10/26 11:08:48]

Done.

   bool isFunction() => identical(kind, ElementKind.FUNCTION);
   bool isConstructor() => isFactoryConstructor() || isGenerativeConstructor();
   bool isClosure() => false;
   bool isMember() {
     // Check that this element is defined in the scope of a Class.
     return enclosingElement != null && enclosingElement.isClass();
   }
   bool isInstanceMember() => false;
   bool isFactoryConstructor() => modifiers.isFactory();
   bool isGenerativeConstructor() =>
@@ skipping 1484 matching lines @@
       return 'origin ${super.toString()}';
     } else {
       return super.toString();
     }
   }
 }
 
 class Elements {
   static bool isUnresolved(Element e) => e == null || e.isErroneous();
   static bool isErroneousElement(Element e) => e != null && e.isErroneous();
+  static bool isValid(Element e) => !isUnresolved(e);

[ahe, 2012/10/25 14:07:27]

A documentation comment would also be great here.

[karlklose, 2012/10/26 11:08:48]

Done.

 
   static bool isLocal(Element element) {
     return !Elements.isUnresolved(element)
             && !element.isInstanceMember()
             && !isStaticOrTopLevelField(element)
             && !isStaticOrTopLevelFunction(element)
             && (identical(element.kind, ElementKind.VARIABLE) ||
                 identical(element.kind, ElementKind.PARAMETER) ||
                 identical(element.kind, ElementKind.FUNCTION));
   }
@@ skipping 270 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }