Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: ui/gfx/render_text_mac.cc

Issue 11269022: Add Vector2d classes that represent offsets, instead of using Point. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more vector use fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_mac.cc
diff --git a/ui/gfx/render_text_mac.cc b/ui/gfx/render_text_mac.cc
index 9ee069f1a60a63089c44b9b15dc59cc532c0f541..83e2ee3682e30f63e627de6608bb16caf4b26b51 100644
--- a/ui/gfx/render_text_mac.cc
+++ b/ui/gfx/render_text_mac.cc
@@ -232,9 +232,9 @@ void RenderTextMac::ComputeRuns() {
CFArrayRef ct_runs = CTLineGetGlyphRuns(line_);
const CFIndex ct_runs_count = CFArrayGetCount(ct_runs);
- Point offset(GetTextOrigin());
+ Vector2d offset(GetTextOffset());
// Skia will draw glyphs with respect to the baseline.
- offset.Offset(0, common_baseline_);
+ offset.Grow(0, common_baseline_);
Peter Kasting 2012/10/30 01:14:14 Nit: Inline this addition into the SkIntToScalar c
danakj 2012/10/30 19:21:21 Then we need to inline it also into the run_origin
Peter Kasting 2012/10/30 20:24:37 No, I forgot to mention. We should also have run_
danakj 2012/10/30 21:14:52 Oh I see, yes.
const SkScalar x = SkIntToScalar(offset.x());
const SkScalar y = SkIntToScalar(offset.y());

Powered by Google App Engine
This is Rietveld 408576698