Add Vector2d classes that represent offsets, instead of using Point.

ui/gfx/render_text_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text_mac.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 214 matching lines @@
     }
   }
 }
 
 void RenderTextMac::ComputeRuns() {
   DCHECK(line_);
 
   CFArrayRef ct_runs = CTLineGetGlyphRuns(line_);
   const CFIndex ct_runs_count = CFArrayGetCount(ct_runs);
 
-  Point offset(GetTextOrigin());
+  Vector2d offset(GetTextOffset());
   // Skia will draw glyphs with respect to the baseline.
-  offset.Offset(0, common_baseline_);
+  offset.Grow(0, common_baseline_);

[Peter Kasting, 2012/10/30 01:14:14]

Nit: Inline this addition into the SkIntToScalar call below.

[danakj, 2012/10/30 19:21:21]

Then we need to inline it also into the run_origin line as well, duplicating
this logic. Prefer to keep this one as it is.

[Peter Kasting, 2012/10/30 20:24:37]

No, I forgot to mention.  We should also have run_origin do:

  SkPoint run_origin = {x, y};

(Or optionally SkPoint::Make(x, y);, but that's less efficient and more
verbose.)

It wants SkScalars anyway, so it makes sense to supply the ones we already
calculated.

[danakj, 2012/10/30 21:14:52]

Oh I see, yes.

 
   const SkScalar x = SkIntToScalar(offset.x());
   const SkScalar y = SkIntToScalar(offset.y());
   SkPoint run_origin = SkPoint::Make(offset.x(), offset.y());
 
   const CFRange empty_cf_range = CFRangeMake(0, 0);
   for (CFIndex i = 0; i < ct_runs_count; ++i) {
     CTRunRef ct_run =
         base::mac::CFCast<CTRunRef>(CFArrayGetValueAtIndex(ct_runs, i));
     const size_t glyph_count = CTRunGetGlyphCount(ct_run);
@@ skipping 67 matching lines @@
     run_origin.offset(run_width, 0);
   }
   runs_valid_ = true;
 }
 
 RenderText* RenderText::CreateInstance() {
   return new RenderTextMac;
 }
 
 }  // namespace gfx