Add Vector2d classes that represent offsets, instead of using Point.

chrome/browser/ui/gtk/download/download_shelf_gtk.cc

Index: chrome/browser/ui/gtk/download/download_shelf_gtk.cc
diff --git a/chrome/browser/ui/gtk/download/download_shelf_gtk.cc b/chrome/browser/ui/gtk/download/download_shelf_gtk.cc
index 054a9dccf5046e4f04968868ba3386e300e574c1..662a79f7c00389d437b52a00448b5f210fbf1438 100644
--- a/chrome/browser/ui/gtk/download/download_shelf_gtk.cc
+++ b/chrome/browser/ui/gtk/download/download_shelf_gtk.cc
@@ -383,11 +383,7 @@ bool DownloadShelfGtk::IsCursorInShelfZone(
   if (!realized)
     return false;
 
-  GtkAllocation allocation;
-  gtk_widget_get_allocation(shelf_.get(), &allocation);
-
-  gfx::Rect bounds(ui::GetWidgetScreenPosition(shelf_.get()),
-                   gfx::Size(allocation.width, allocation.height));
+  gfx::Rect bounds = ui::GetWidgetScreenBounds(shelf_.get());

[Peter Kasting, 2012/10/29 23:06:33]

I don't know Gtk enough to ensure this does the same thing as the old code.

[danakj, 2012/10/29 23:21:41]

New code calls this:

gfx::Rect GetWidgetScreenBounds(GtkWidget* widget) {
  gfx::Point position = PointAtOffsetFromOrigin(GetWidgetScreenOffset(widget));

  GtkAllocation allocation;
  gtk_widget_get_allocation(widget, &allocation);

  return gfx::Rect(position.x(), position.y(),
                   allocation.width, allocation.height);
}

This is the same as what we're deleting here % s/position/offset/

 
   // Negative insets expand the rectangle. We only expand the top.
   bounds.Inset(gfx::Insets(-kShelfAuraSize, 0, 0, 0));