Add Vector2d classes that represent offsets, instead of using Point.

chrome/browser/ui/gtk/download/download_shelf_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/download/download_shelf_gtk.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "chrome/browser/download/download_item_model.h"
@@ skipping 365 matching lines @@
 
 bool DownloadShelfGtk::IsCursorInShelfZone(
     const gfx::Point& cursor_screen_coords) {
   bool realized = (shelf_.get() &&
                    gtk_widget_get_window(shelf_.get()));
   // Do nothing if we've been unrealized in order to avoid a NOTREACHED in
   // GetWidgetScreenPosition.
   if (!realized)
     return false;
 
-  GtkAllocation allocation;
-  gtk_widget_get_allocation(shelf_.get(), &allocation);
-
-  gfx::Rect bounds(ui::GetWidgetScreenPosition(shelf_.get()),
-                   gfx::Size(allocation.width, allocation.height));
+  gfx::Rect bounds = ui::GetWidgetScreenBounds(shelf_.get());

[Peter Kasting, 2012/10/29 23:06:33]

I don't know Gtk enough to ensure this does the same thing as the old code.

[danakj, 2012/10/29 23:21:41]

New code calls this:

gfx::Rect GetWidgetScreenBounds(GtkWidget* widget) {
  gfx::Point position = PointAtOffsetFromOrigin(GetWidgetScreenOffset(widget));

  GtkAllocation allocation;
  gtk_widget_get_allocation(widget, &allocation);

  return gfx::Rect(position.x(), position.y(),
                   allocation.width, allocation.height);
}

This is the same as what we're deleting here % s/position/offset/

 
   // Negative insets expand the rectangle. We only expand the top.
   bounds.Inset(gfx::Insets(-kShelfAuraSize, 0, 0, 0));
 
   return bounds.Contains(cursor_screen_coords);
 }
 
 void DownloadShelfGtk::MouseLeftShelf() {
   DCHECK(close_on_mouse_out_);
 
   MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       base::Bind(&DownloadShelfGtk::Close, weak_factory_.GetWeakPtr()),
       base::TimeDelta::FromMilliseconds(kAutoCloseDelayMs));
 }
 
 void DownloadShelfGtk::MouseEnteredShelf() {
   weak_factory_.InvalidateWeakPtrs();
 }