Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: ash/tooltips/tooltip_controller.cc

Issue 11269022: Add Vector2d classes that represent offsets, instead of using Point. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/tooltips/tooltip_controller.cc
diff --git a/ash/tooltips/tooltip_controller.cc b/ash/tooltips/tooltip_controller.cc
index 45c4785c081f034c93ce8c86c013bb5c6f1490fa..047975d538850ecb6fbf987d56b9ebeb7d1dbbc3 100644
--- a/ash/tooltips/tooltip_controller.cc
+++ b/ash/tooltips/tooltip_controller.cc
@@ -452,7 +452,7 @@ void TooltipController::UpdateIfRequired() {
string16 tooltip_text(tooltip_text_);
gfx::Point widget_loc = curr_mouse_loc_;
Peter Kasting 2012/10/27 01:01:39 Nit: Inline both of these statements into the SetT
danakj 2012/10/29 19:17:20 Done.
widget_loc = widget_loc.Add(
- tooltip_window_->GetBoundsInScreen().origin());
+ tooltip_window_->GetBoundsInScreen().OffsetFromOrigin());
Peter Kasting 2012/10/27 01:01:39 Can we replace GetBoundsInScreen() with a function
danakj 2012/10/29 19:17:20 I don't think we want to replace the method. There
GetTooltip()->SetText(tooltip_text, widget_loc);
GetTooltip()->Show();
tooltip_shown_timer_.Start(FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698