Index: chrome/installer/util/chrome_app_host_distribution.cc |
diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc |
index da20de6eea52160ba90b34098ae5ed3d09c03557..ca6629796dd080867c3d99a6fbc073a93feb012a 100644 |
--- a/chrome/installer/util/chrome_app_host_distribution.cc |
+++ b/chrome/installer/util/chrome_app_host_distribution.cc |
@@ -48,6 +48,8 @@ string16 ChromeAppHostDistribution::GetAlternateApplicationName() { |
return product_name; |
} |
+// TODO(huangs): Override ChromeAppHostDistribution::GetBaseAppId(). |
erikwright (departed)
2012/10/31 19:41:13
I don't think a TODO is needed for this as part of
huangs
2012/10/31 20:49:31
Done.
|
+ |
string16 ChromeAppHostDistribution::GetInstallSubDir() { |
return BrowserDistribution::GetSpecificDistribution( |
BrowserDistribution::CHROME_BINARIES)->GetInstallSubDir(); |
@@ -60,15 +62,15 @@ string16 ChromeAppHostDistribution::GetPublisherName() { |
} |
string16 ChromeAppHostDistribution::GetAppDescription() { |
- NOTREACHED() << "This should never be accessed due to no start-menu/task-bar " |
- << "shortcuts."; |
- return L"A standalone platform for Chrome apps."; |
+ const string16& app_description = |
+ installer::GetLocalizedString(IDS_APP_LAUNCHER_SHORTCUT_TOOLTIP_BASE); |
+ return app_description; |
} |
string16 ChromeAppHostDistribution::GetLongAppDescription() { |
- NOTREACHED() << "This should never be accessed as Chrome App Host is not a " |
- << "default browser option."; |
- return L"A standalone platform for Chrome apps."; |
+ const string16& app_description = |
+ installer::GetLocalizedString(IDS_APP_LAUNCHER_PRODUCT_DESCRIPTION_BASE); |
+ return app_description; |
} |
std::string ChromeAppHostDistribution::GetSafeBrowsingName() { |
@@ -102,14 +104,10 @@ std::string ChromeAppHostDistribution::GetHttpPipeliningTestServer() const { |
} |
string16 ChromeAppHostDistribution::GetUninstallLinkName() { |
- NOTREACHED() << "This should never be accessed as Chrome App Host has no " |
- << "uninstall entry."; |
return L"Uninstall Chrome App Host"; |
erikwright (departed)
2012/10/31 19:41:13
internationalize
huangs
2012/10/31 20:49:31
Done.
|
} |
string16 ChromeAppHostDistribution::GetUninstallRegPath() { |
- NOTREACHED() << "This should never be accessed as Chrome App Host has no " |
- << "uninstall entry."; |
return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\" |
L"Google Chrome App Host"; |
} |
@@ -126,6 +124,7 @@ bool ChromeAppHostDistribution::CanSetAsDefault() { |
} |
bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() { |
+ // TODO(huangs): return true. |
erikwright (departed)
2012/10/31 19:41:13
Not needed at this point.
huangs
2012/10/31 20:49:31
Done.
|
return false; |
} |