Implementing --app-launcher install/uninstall flow.

chrome/installer/util/chrome_app_host_distribution.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines a specific implementation of BrowserDistribution class for
 // Chrome App Host. It overrides the bare minimum of methods necessary to get a
 // Chrome App Host installer that does not interact with Google Chrome or
 // Chromium installations.
 
 #include "chrome/installer/util/chrome_app_host_distribution.h"
@@ skipping 30 matching lines @@
       installer::GetLocalizedString(IDS_PRODUCT_APP_HOST_NAME_BASE);
   return product_name;
 }
 
 string16 ChromeAppHostDistribution::GetAlternateApplicationName() {
   const string16& product_name =
       installer::GetLocalizedString(IDS_PRODUCT_APP_HOST_NAME_BASE);
   return product_name;
 }
 
+// TODO(huangs): Override ChromeAppHostDistribution::GetBaseAppId().

[erikwright (departed), 2012/10/31 19:41:13]

I don't think a TODO is needed for this as part of this CL.

[huangs, 2012/10/31 20:49:31]

Done.

+
 string16 ChromeAppHostDistribution::GetInstallSubDir() {
   return BrowserDistribution::GetSpecificDistribution(
       BrowserDistribution::CHROME_BINARIES)->GetInstallSubDir();
 }
 
 string16 ChromeAppHostDistribution::GetPublisherName() {
   const string16& publisher_name =
       installer::GetLocalizedString(IDS_ABOUT_VERSION_COMPANY_NAME_BASE);
   return publisher_name;
 }
 
 string16 ChromeAppHostDistribution::GetAppDescription() {
-  NOTREACHED() << "This should never be accessed due to no start-menu/task-bar "
-               << "shortcuts.";
-  return L"A standalone platform for Chrome apps.";
+  const string16& app_description =
+      installer::GetLocalizedString(IDS_APP_LAUNCHER_SHORTCUT_TOOLTIP_BASE);
+  return app_description;
 }
 
 string16 ChromeAppHostDistribution::GetLongAppDescription() {
-  NOTREACHED() << "This should never be accessed as Chrome App Host is not a "
-               << "default browser option.";
-  return L"A standalone platform for Chrome apps.";
+  const string16& app_description =
+      installer::GetLocalizedString(IDS_APP_LAUNCHER_PRODUCT_DESCRIPTION_BASE);
+  return app_description;
 }
 
 std::string ChromeAppHostDistribution::GetSafeBrowsingName() {
   return "googlechromeapphost";
 }
 
 string16 ChromeAppHostDistribution::GetStateKey() {
   string16 key(google_update::kRegPathClientState);
   key.append(L"\\");
   key.append(kChromeAppHostGuid);
@@ skipping 13 matching lines @@
 
 std::string ChromeAppHostDistribution::GetNetworkStatsServer() const {
   return chrome_common_net::kEchoTestServerLocation;
 }
 
 std::string ChromeAppHostDistribution::GetHttpPipeliningTestServer() const {
   return chrome_common_net::kPipelineTestServerBaseUrl;
 }
 
 string16 ChromeAppHostDistribution::GetUninstallLinkName() {
-  NOTREACHED() << "This should never be accessed as Chrome App Host has no "
-               << "uninstall entry.";
   return L"Uninstall Chrome App Host";

[erikwright (departed), 2012/10/31 19:41:13]

internationalize

[huangs, 2012/10/31 20:49:31]

Done.

 }
 
 string16 ChromeAppHostDistribution::GetUninstallRegPath() {
-  NOTREACHED() << "This should never be accessed as Chrome App Host has no "
-               << "uninstall entry.";
   return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\"
          L"Google Chrome App Host";
 }
 
 string16 ChromeAppHostDistribution::GetVersionKey() {
   string16 key(google_update::kRegPathClients);
   key.append(L"\\");
   key.append(kChromeAppHostGuid);
   return key;
 }
 
 bool ChromeAppHostDistribution::CanSetAsDefault() {
   return false;
 }
 
 bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() {
+  // TODO(huangs): return true.

[erikwright (departed), 2012/10/31 19:41:13]

Not needed at this point.

[huangs, 2012/10/31 20:49:31]

Done.

   return false;
 }
 
 bool ChromeAppHostDistribution::GetCommandExecuteImplClsid(
     string16* handler_class_uuid) {
   return false;
 }
 
 void ChromeAppHostDistribution::UpdateInstallStatus(bool system_install,
     installer::ArchiveType archive_type,
     installer::InstallStatus install_status) {
 #if defined(GOOGLE_CHROME_BUILD)
   GoogleUpdateSettings::UpdateInstallStatus(system_install,
       archive_type, InstallUtil::GetInstallReturnCode(install_status),
       kChromeAppHostGuid);
 #endif
 }