Issue 11253: Fixes trees on Hebrew locales. The current code was problematic...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11253: Fixes trees on Hebrew locales. The current code was problematic... (Closed)

Created:
12 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes trees on Hebrew locales. The current code was problematic because SetWorldTransform and a graphics mode of COMPATIBLE don't work together. Instead we must use SetViewportOrgEx. BUG=4515 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5654

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	chrome/views/tree_view.cc	View	1	1 chunk	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/11253/diff/1/2 File chrome/views/tree_view.cc (right): http://codereview.chromium.org/11253/diff/1/2#newcode655 Line 655: SetWorldTransform(dc, &xform); Can you explain the concept of ...

12 years, 1 month ago (2008-11-19 00:06:00 UTC) #2

LGTM

Expand Messages | Collapse Messages