Fixes trees on Hebrew locales. The current code was problematic...

chrome/views/tree_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/views/tree_view.h"
 
 #include <shellapi.h>
 
 #include "base/win_util.h"
 #include "chrome/app/theme/theme_resources.h"
@@ skipping 624 matching lines @@
   // flickering during resize.
   switch (message) {
     case WM_ERASEBKGND:
       return 1;
 
     case WM_PAINT: {
       ChromeCanvasPaint canvas(window);
       if (canvas.isEmpty())
         return 0;
 
-      HDC dc =  canvas.beginPlatformPaint();
+      HDC dc = canvas.beginPlatformPaint();
       if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
         // ChromeCanvas ends up configuring the DC with a mode of GM_ADVANCED.
         // For some reason a graphics mode of ADVANCED triggers all the text
         // to be mirrored when RTL. Set the mode back to COMPATIBLE and
-        // explicitly set the layout.
+        // explicitly set the layout. Additionally SetWorldTransform and
+        // COMPATIBLE don't play nicely together. We need to use
+        // SetViewportOrgEx when using a mode of COMPATIBLE.
+        //
+        // Reset the transform to the identify transform. Even though
+        // SetWorldTransform and COMPATIBLE don't play nicely, bits of the
+        // transform still carry over when we set the mode.
+        XFORM xform = {0};
+        xform.eM11 = xform.eM22 = 1;
+        SetWorldTransform(dc, &xform);
+
+        // Set the mode and layout.
         SetGraphicsMode(dc, GM_COMPATIBLE);
         SetLayout(dc, LAYOUT_RTL);
+
+        // Transform the viewport such that the origin of the dc is that of
+        // the dirty region. This way when we invoke WM_PRINTCLIENT tree-view
+        // draws the dirty region at the origin of the DC so that when we
+        // copy the bits everything lines up nicely. Without this we end up
+        // copying the upper-left corner to the redraw region.
+        SetViewportOrgEx(dc, -canvas.paintStruct().rcPaint.left,
+                         -canvas.paintStruct().rcPaint.top, NULL);
       }
       SendMessage(window, WM_PRINTCLIENT, reinterpret_cast<WPARAM>(dc), 0);
+      if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+        // Reset the origin of the dc back to 0. This way when we copy the bits
+        // over we copy the right bits.
+        SetViewportOrgEx(dc, 0, 0, NULL);
+      }
       canvas.endPlatformPaint();
       return 0;
     }
 
     case WM_RBUTTONDOWN:
       if (tree->select_on_right_mouse_down_) {
         TVHITTESTINFO hit_info;
         hit_info.pt.x = GET_X_LPARAM(l_param);
         hit_info.pt.y = GET_Y_LPARAM(l_param);
         HTREEITEM hit_item = TreeView_HitTest(window, &hit_info);
         if (hit_item && (hit_info.flags & (TVHT_ONITEM | TVHT_ONITEMRIGHT |
                                            TVHT_ONITEMINDENT)) != 0)
           TreeView_SelectItem(tree->tree_view_, hit_item);
       }
       // Fall through and let the default handler process as well.
       break;
   }
   WNDPROC handler = tree->original_handler_;
   DCHECK(handler);
   return CallWindowProc(handler, window, message, w_param, l_param);
 }
 
 }  // namespace views