Update location of autotest files in image_to_usb, fix loopback mounting for stateful partition

Update location of autotest files in image_to_usb, fix loopback mounting for stateful partition

[sosa, 2010-03-19 20:31:12]

http://codereview.chromium.org/1125004/diff/1/2
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1125004/diff/1/2#newcode133
src/scripts/image_to_usb.sh:133: sudo umount ${STATEFUL_DIR}
Potentially lose a loopback device if someone Ctrl+C's here

[kmixter1, 2010-03-19 21:11:10]

http://codereview.chromium.org/1125004/diff/1/2
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1125004/diff/1/2#newcode133
src/scripts/image_to_usb.sh:133: sudo umount ${STATEFUL_DIR}
On 2010/03/19 20:31:12, sosa wrote:
> Potentially lose a loopback device if someone Ctrl+C's here

Nick, you mentioned you switched to using -o loop because the old sequence of
commands would fail on your machine.  Could you send the failure?

[Raja Aluri, 2010-03-19 21:22:49]

http://codereview.chromium.org/1125004/diff/1/2
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1125004/diff/1/2#newcode36
src/scripts/image_to_usb.sh:36:
AUTOTEST_SRC="/build/${FLAGS_board}/usr/local/autotest"
setup_board takes --build-root an an argument. '/build' is just the default. if
anybody uses --build-root to point to somewhere else. then this script will not
work.

http://codereview.chromium.org/1125004/diff/1/2#newcode38
src/scripts/image_to_usb.sh:38:
AUTOTEST_SRC="${DEFAULT_CHROOT_DIR}/build/${FLAGS_board}/usr/local/autotest"
same as above comment

[Nick Sanders, 2010-03-19 21:31:54]

It would hang on mount, looking onto it further I think it was because
there's no
sudo losetup "${stateful_loop_dev}" "${STATEFUL_DIR}.image"
before
sudo mount "${stateful_loop_dev}" "${STATEFUL_DIR}"

So the loopback device is not associated with any file at that point?
I'm not really familiar with loopback devices or bash generally..
Also, regarding the do_cleanup, it looks like that's an exit handler, but
I don't see where LOOP_DEV is set?

On Fri, Mar 19, 2010 at 2:11 PM, <kmixter@chromium.org> wrote:

>
> http://codereview.chromium.org/1125004/diff/1/2
> File src/scripts/image_to_usb.sh (right):
>
> http://codereview.chromium.org/1125004/diff/1/2#newcode133
> src/scripts/image_to_usb.sh:133: sudo umount ${STATEFUL_DIR}
> On 2010/03/19 20:31:12, sosa wrote:
>
>> Potentially lose a loopback device if someone Ctrl+C's here
>>
>
> Nick, you mentioned you switched to using -o loop because the old
> sequence of commands would fail on your machine.  Could you send the
> failure?
>
>
> http://codereview.chromium.org/1125004
>

[sosa, 2010-03-19 21:37:12]

Nick you're right.  I moved some code around earlier and didn't test it.  Your
fix works.  I can go back and make a new cleanup function later

lgtm

[kmixter1, 2010-03-19 22:32:18]

+waihong

[Nick Sanders, 2010-03-19 22:35:23]

I've added loop device unleaking, and a build root option.


On Fri, Mar 19, 2010 at 3:32 PM, <kmixter@chromium.org> wrote:

> +waihong
>
>
> http://codereview.chromium.org/1125004
>

[Nick Sanders, 2010-03-19 22:38:45]

http://codereview.chromium.org/1125004/diff/3/8001
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1125004/diff/3/8001#newcode40
src/scripts/image_to_usb.sh:40:
AUTOTEST_SRC="${DEFAULT_CHROOT_DIR}${FLAGS_build_root}/${FLAGS_board}/usr/local/autotest"
Is >80 char ok, or should I "\"?

[kmixter1, 2010-03-19 22:47:41]

LGTM

http://codereview.chromium.org/1125004/diff/3/8001
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1125004/diff/3/8001#newcode40
src/scripts/image_to_usb.sh:40:
AUTOTEST_SRC="${DEFAULT_CHROOT_DIR}${FLAGS_build_root}/${FLAGS_board}/usr/local/autotest"
On 2010/03/19 22:38:45, nsanders1 wrote:
> Is >80 char ok, or should I "\"?

better to use \.  I usually create two paths in these cases to not mess up
indentation.  Call AUTOTEST_SRC just "SYSROOT" which is just up to the board and
then define AUTOTEST_SRC outside the if.

http://codereview.chromium.org/1125004/diff/3/8001#newcode148
src/scripts/image_to_usb.sh:148: local autotest_client="/home/autotest-client"
please fix indent here (and thx for getting rid of the tabs).