Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6528)

Unified Diff: chrome/browser/profiles/off_the_record_profile_impl.cc

Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Increased similarity threshold... Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/off_the_record_profile_impl.cc
diff --git a/chrome/browser/profiles/off_the_record_profile_impl.cc b/chrome/browser/profiles/off_the_record_profile_impl.cc
index 75d42a62520d1dfa419c5cc24a9833f88e5261a2..1d80409c4c5c828269f95c2f29bd45b501b5fdf8 100644
--- a/chrome/browser/profiles/off_the_record_profile_impl.cc
+++ b/chrome/browser/profiles/off_the_record_profile_impl.cc
@@ -452,8 +452,16 @@ chrome_browser_net::Predictor* OffTheRecordProfileImpl::GetNetworkPredictor() {
return NULL;
}
-void OffTheRecordProfileImpl::ClearNetworkingHistorySince(base::Time time) {
+void OffTheRecordProfileImpl::ClearNetworkingHistorySince(
+ base::Time time,
+ const base::Closure& completion) {
// No need to do anything here, our transport security state is read-only.
+ // Fire the callback that indicates we have finished. Otherwise BrowsingData-
+ // Remover will never be destroyed and the dialog will never be closed. Also,
mmenke 2012/10/26 19:06:20 nit: Don't think I've ever seen words split like
engedy 2012/10/29 14:37:56 Done.
+ // do this asynchronously, to avoid reentrancy issues.
+ if (!completion.is_null()) {
+ BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, completion);
+ }
}
GURL OffTheRecordProfileImpl::GetHomePage() {

Powered by Google App Engine
This is Rietveld 408576698