Added completion notification to Profile's ClearNetworkingHistorySince.

chrome/browser/profiles/off_the_record_profile_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/off_the_record_profile_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
@@ skipping 434 matching lines @@
   }
   return pref_proxy_config_tracker_.get();
 }
 
 chrome_browser_net::Predictor* OffTheRecordProfileImpl::GetNetworkPredictor() {
   // We do not store information about websites visited in OTR profiles which
   // is necessary for a Predictor, so we do not have a Predictor at all.
   return NULL;
 }
 
-void OffTheRecordProfileImpl::ClearNetworkingHistorySince(base::Time time) {
+void OffTheRecordProfileImpl::ClearNetworkingHistorySince(
+    base::Time time,
+    const base::Closure& completion) {
   // No need to do anything here, our transport security state is read-only.
+  // Fire the callback that indicates we have finished. Otherwise BrowsingData-
+  // Remover will never be destroyed and the dialog will never be closed. Also,

[mmenke, 2012/10/26 19:06:20]

nit:  Don't think I've ever seen words split like this in the Chrome code base. 
Just use BrowserDataRemover, and wrap the line.

[engedy, 2012/10/29 14:37:56]

Done.

+  // do this asynchronously, to avoid reentrancy issues.
+  if (!completion.is_null()) {
+    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, completion);
+  }
 }
 
 GURL OffTheRecordProfileImpl::GetHomePage() {
   return profile_->GetHomePage();
 }
 
 void OffTheRecordProfileImpl::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
@@ skipping 39 matching lines @@
   if (!profile)
     profile = new OffTheRecordProfileImpl(this);
   profile->Init();
   return profile;
 }
 
 base::Callback<ChromeURLDataManagerBackend*(void)>
     OffTheRecordProfileImpl::GetChromeURLDataManagerBackendGetter() const {
   return io_data_.GetChromeURLDataManagerBackendGetter();
 }