Test that debug stub works with browser.

net/base/tcp_listen_socket.h

Index: net/base/tcp_listen_socket.h
===================================================================
--- net/base/tcp_listen_socket.h	(revision 163266)
+++ net/base/tcp_listen_socket.h	(working copy)
@@ -25,6 +25,8 @@
   // Get raw TCP socket descriptor bound to ip:port.
   static SocketDescriptor CreateAndBind(const std::string& ip, int port);
 
+  static int GetBindedPort(SocketDescriptor s);

[Mark Seaborn, 2012/10/23 01:14:50]

GetBoundPort()?  This needs a comment to explain that it returns the port number
bound in the case where the OS chooses the port, when port=0 is passed to
CreateAndBind().

Actually, it would be cleaner to instead add:

  static SocketDescriptor CreateAndBindAnyPort(const std::string& ip, int
*port);

[szym, 2012/10/23 02:08:48]

suggest: GetBoundPort.

I'd generally prefer if all three of those methods were wrapped in a proper
class and NaClProcessHost held an instance of a TCPListenSocket.

[halyavin, 2012/10/23 11:59:29]

Done.

+
  protected:
   friend class scoped_refptr<TCPListenSocket>;