Test that debug stub works with browser.

net/base/tcp_listen_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_TCP_LISTEN_SOCKET_H_
 #define NET_BASE_TCP_LISTEN_SOCKET_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "net/base/net_export.h"
 #include "net/base/stream_listen_socket.h"
 
 namespace net {
 
 // Implements a TCP socket. Note that this is ref counted.
 class NET_EXPORT TCPListenSocket : public StreamListenSocket {
  public:
   // Listen on port for the specified IP address.  Use 127.0.0.1 to only
   // accept local connections.
   static scoped_refptr<TCPListenSocket> CreateAndListen(
       const std::string& ip, int port, StreamListenSocket::Delegate* del);
 
   // Get raw TCP socket descriptor bound to ip:port.
   static SocketDescriptor CreateAndBind(const std::string& ip, int port);
 
+  static int GetBindedPort(SocketDescriptor s);

[Mark Seaborn, 2012/10/23 01:14:50]

GetBoundPort()?  This needs a comment to explain that it returns the port number
bound in the case where the OS chooses the port, when port=0 is passed to
CreateAndBind().

Actually, it would be cleaner to instead add:

  static SocketDescriptor CreateAndBindAnyPort(const std::string& ip, int
*port);

[szym, 2012/10/23 02:08:48]

suggest: GetBoundPort.

I'd generally prefer if all three of those methods were wrapped in a proper
class and NaClProcessHost held an instance of a TCPListenSocket.

[halyavin, 2012/10/23 11:59:29]

Done.

+
  protected:
   friend class scoped_refptr<TCPListenSocket>;
 
   TCPListenSocket(SocketDescriptor s, StreamListenSocket::Delegate* del);
   virtual ~TCPListenSocket();
 
   // Implements StreamListenSocket::Accept.
   virtual void Accept() OVERRIDE;
 
  private:
@@ skipping 13 matching lines @@
  private:
   const std::string ip_;
   const int port_;
 
   DISALLOW_COPY_AND_ASSIGN(TCPListenSocketFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_TCP_LISTEN_SOCKET_H_