Fix spurious visibility events when committing Instant.

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index c358123243f1adef5128fe3d6103edac0c27bb33..c1aaffba41fd1ebaddee42a219ace4d4598deb30 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1380,6 +1380,17 @@ ToolbarView* BrowserView::GetToolbarView() const {
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserView, TabStripModelObserver implementation:
 
+void BrowserView::TabInsertedAt(TabContents* contents, int index, bool active) {

[sky, 2012/10/24 03:51:16]

Why can't we wait until ActiveTabChanged?

[sreeram, 2012/10/24 16:46:45]

I suppose we could. However, I plan to add support for the NEW_BACKGROUND_TAB
disposition as well very soon, at which time, we'll definitely need this method.

[sky, 2012/10/24 20:49:26]

I don't like adding another method that overlaps with the existing one. Use the
existing one until we really need this.

[sreeram, 2012/10/25 00:44:33]

Done. In fact, I realized that pretty much everything can be consolidated into
ActiveTabChanged. So I've removed the insert/replace tab events from both views
& cocoa (gtk always just used active tab event). I've also updated the test to
be check the visibility transitions more thoroughly.

+  if (contents_->preview_web_contents() == contents->web_contents() && active) {
+#if defined(USE_AURA)
+    if (search_view_controller_.get())
+      search_view_controller_->WillCommitInstant();
+#endif
+    contents_container_ = preview_controller_->release_preview_container();
+    contents_->MakePreviewContentsActiveContents();
+  }
+}
+
 void BrowserView::TabDetachedAt(TabContents* contents, int index) {
   // We use index here rather than comparing |contents| because by this time
   // the model has already removed |contents| from its list, so