Fix spurious visibility events when committing Instant.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1362 matching lines @@
   return contents_container_;
 }
 
 ToolbarView* BrowserView::GetToolbarView() const {
   return toolbar_;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserView, TabStripModelObserver implementation:
 
+void BrowserView::TabInsertedAt(TabContents* contents, int index, bool active) {

[sky, 2012/10/24 03:51:16]

Why can't we wait until ActiveTabChanged?

[sreeram, 2012/10/24 16:46:45]

I suppose we could. However, I plan to add support for the NEW_BACKGROUND_TAB
disposition as well very soon, at which time, we'll definitely need this method.

[sky, 2012/10/24 20:49:26]

I don't like adding another method that overlaps with the existing one. Use the
existing one until we really need this.

[sreeram, 2012/10/25 00:44:33]

Done. In fact, I realized that pretty much everything can be consolidated into
ActiveTabChanged. So I've removed the insert/replace tab events from both views
& cocoa (gtk always just used active tab event). I've also updated the test to
be check the visibility transitions more thoroughly.

+  if (contents_->preview_web_contents() == contents->web_contents() && active) {
+#if defined(USE_AURA)
+    if (search_view_controller_.get())
+      search_view_controller_->WillCommitInstant();
+#endif
+    contents_container_ = preview_controller_->release_preview_container();
+    contents_->MakePreviewContentsActiveContents();
+  }
+}
+
 void BrowserView::TabDetachedAt(TabContents* contents, int index) {
   // We use index here rather than comparing |contents| because by this time
   // the model has already removed |contents| from its list, so
   // browser_->GetActiveWebContents() will return NULL or something else.
   if (index == browser_->active_index()) {
     // We need to reset the current tab contents to NULL before it gets
     // freed. This is because the focus manager performs some operations
     // on the selected WebContents when it is removed.
     contents_container_->SetWebContents(NULL);
     infobar_container_->ChangeTabContents(NULL);
@@ skipping 1246 matching lines @@
 
   Browser* modal_browser =
       browser::FindBrowserWithWebContents(active_dialog->web_contents());
   if (modal_browser && (browser_ != modal_browser)) {
     modal_browser->window()->FlashFrame(true);
     modal_browser->window()->Activate();
   }
 
   AppModalDialogQueue::GetInstance()->ActivateModalDialog();
 }