Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4534)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 11233076: Fix spurious visibility events when committing Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 5bf5d07407aace99a8e9ce0e97008f686b7457f3..d63418a1cf8419381a32134b859c6d6cd0b861ed 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1557,9 +1557,7 @@ enum {
}
- (void)onReplaceTabWithContents:(WebContents*)contents {
- // Simply remove the preview view if it exists; the tab strip
- // controller will reinstall the view as the active view.
- [previewableContentsController_ hidePreview];
+ [previewableContentsController_ onActivateTabWithContents:contents];
[self updateBookmarkBarVisibilityWithAnimation:NO];
}
@@ -1585,7 +1583,7 @@ enum {
}
- (void)onInsertTabWithContents:(WebContents*)contents {
- [previewableContentsController_ onInsertTabWithContents:contents];
+ [previewableContentsController_ onActivateTabWithContents:contents];
}
- (void)userChangedTheme {

Powered by Google App Engine
This is Rietveld 408576698