Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: media/audio/audio_output_controller.cc

Issue 11233023: Handle audio device changes on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments! Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_controller.cc
diff --git a/media/audio/audio_output_controller.cc b/media/audio/audio_output_controller.cc
index cd237af111b1c96dd47aa8fee834476c0af38177..8f98ca51f5537ecbd8076e1bceed11876b644414 100644
--- a/media/audio/audio_output_controller.cc
+++ b/media/audio/audio_output_controller.cc
@@ -366,6 +366,14 @@ void AudioOutputController::OnDeviceChange() {
// We should always have a stream by this point.
CHECK(stream_);
+ // We only need to reconnect low latency streams.
+ // TODO(dalecurtis): Ideally AudioOutputController shouldn't have to make this
+ // decision, but for now it's the only object which holds the necessary pieces
+ // of information. Eventually we'll get rid of the non-low latency audio
+ // implementations and this can be dropped at that time.
scherkus (not reviewing) 2012/10/23 02:23:11 ...not as long as we're shipping on XP perhaps a
DaleCurtis 2012/10/23 03:28:20 I was considering WaveOut on XP ~= low latency. T
henrika (OOO until Aug 14) 2012/10/23 07:38:06 Can you make a few tests on a Win7 machine where y
DaleCurtis 2012/10/23 20:09:08 What are you looking to test? I was planning to ha
DaleCurtis 2012/10/24 00:09:27 I decided to do this check in the platform specifi
+ if (params_.format() != AudioParameters::AUDIO_PCM_LOW_LATENCY)
+ return;
+
// Preserve the original state and shutdown the stream.
State original_state = state_;
stream_->Stop();

Powered by Google App Engine
This is Rietveld 408576698