remoting/host/win/worker_process_launcher.cc - Issue 11231060: [Chromoting] The desktop process now creates a pre-connected pipe and passes (with some help of the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/win/worker_process_launcher.cc

Issue 11231060: [Chromoting] The desktop process now creates a pre-connected pipe and passes (with some help of the… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/win/launch_process_with_token.h ('K') | « remoting/host/win/unprivileged_process_delegate.cc ('k') | remoting/host/win/worker_process_launcher_unittest.cc » ('j') | remoting/remoting.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/win/worker_process_launcher.cc

diff --git a/remoting/host/win/worker_process_launcher.cc b/remoting/host/win/worker_process_launcher.cc

index 7e372a387301d2bbb1463e8677a2b64da66da07d..340c2ce18f1ee7c93a3bb1c4868a4209ffaec89a 100644

--- a/remoting/host/win/worker_process_launcher.cc

+++ b/remoting/host/win/worker_process_launcher.cc

@@ -228,6 +228,10 @@ void WorkerProcessLauncher::Core::OnChannelConnected(int32 peer_pid) {

return;

}

+ // Make sure |this| is not deleted if |worker_delegate_| decided to kill

+ // the WorkerProcessLauncher instance.

+ scoped_refptr<Core> self = this;

Sergey Ulanov 2012/10/24 20:12:01 How does that make any difference? This method ret

alexeypa (please no reviews) 2012/10/24 21:41:51 Yeah, this is probably not needed.

worker_delegate_->OnChannelConnected(peer_pid);

}