[Chromoting] The desktop process now creates a pre-connected pipe and passes (with some help of the…

remoting/host/win/worker_process_launcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/win/worker_process_launcher.h"
 
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/time.h"
 #include "base/timer.h"
@@ skipping 210 matching lines @@
   // trusted.
   DWORD actual_pid = launcher_delegate_->GetProcessId();
   if (peer_pid != static_cast<int32>(actual_pid)) {
     LOG(ERROR) << "The actual client PID " << actual_pid
                << " does not match the one reported by the client: "
                << peer_pid;
     StopWorker();
     return;
   }
 
+  // Make sure |this| is not deleted if |worker_delegate_| decided to kill
+  // the WorkerProcessLauncher instance.
+  scoped_refptr<Core> self = this;

[Sergey Ulanov, 2012/10/24 20:12:01]

How does that make any difference? This method returns after calling delegate
anyway.

[alexeypa (please no reviews), 2012/10/24 21:41:51]

Yeah, this is probably not needed.

+
   worker_delegate_->OnChannelConnected(peer_pid);
 }
 
 void WorkerProcessLauncher::Core::OnChannelError() {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   // Schedule a delayed termination of the worker process. Usually, the pipe is
   // disconnected when the worker process is about to exit. Waiting a little bit
   // here allows the worker to exit completely and so, notify
   // |process_watcher_|. As the result KillProcess() will not be called and
@@ skipping 99 matching lines @@
 WorkerProcessLauncher::~WorkerProcessLauncher() {
   core_->Stop();
   core_ = NULL;
 }
 
 void WorkerProcessLauncher::Send(IPC::Message* message) {
   core_->Send(message);
 }
 
 } // namespace remoting