Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 11229015: Add the InvalidationState struct to bundle local state about invalidations. (Closed)

Created:
8 years, 2 months ago by dcheng
Modified:
8 years, 2 months ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, haitaol1, pam+watch_chromium.org, akalin, tim (not reviewing)
Visibility:
Public.

Description

Add the InvalidationState struct to bundle local state about invalidations. Currently this only has one member, but I anticipate adding several more as we add support for local acknowledgements. BUG=124149 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163077

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -151 lines) Patch
M chrome/browser/sync/invalidations/invalidator_storage.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/invalidations/invalidator_storage.cc View 1 8 chunks +47 lines, -47 lines 0 comments Download
M chrome/browser/sync/invalidations/invalidator_storage_unittest.cc View 11 chunks +52 lines, -44 lines 0 comments Download
M sync/notifier/fake_invalidation_state_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/fake_invalidation_state_tracker.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M sync/notifier/invalidation_notifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/invalidation_notifier.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_state_tracker.h View 1 chunk +7 lines, -3 lines 0 comments Download
M sync/notifier/invalidator_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidator_factory.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/non_blocking_invalidator.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/non_blocking_invalidator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_invalidation_listener.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/sync_invalidation_listener.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M sync/notifier/sync_invalidation_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
8 years, 2 months ago (2012-10-19 20:29:28 UTC) #1
akalin
lgtm http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidations/invalidator_storage.cc File chrome/browser/sync/invalidations/invalidator_storage.cc (right): http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidations/invalidator_storage.cc#newcode27 chrome/browser/sync/invalidations/invalidator_storage.cc:27: invalidation::ObjectId* id, fix the indent here http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidations/invalidator_storage_unittest.cc File ...
8 years, 2 months ago (2012-10-19 21:21:26 UTC) #2
dcheng
8 years, 2 months ago (2012-10-19 22:24:40 UTC) #3
http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidati...
File chrome/browser/sync/invalidations/invalidator_storage.cc (right):

http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidati...
chrome/browser/sync/invalidations/invalidator_storage.cc:27:
invalidation::ObjectId* id,
On 2012/10/19 21:21:26, akalin wrote:
> fix the indent here

Done.

http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidati...
File chrome/browser/sync/invalidations/invalidator_storage_unittest.cc (right):

http://codereview.chromium.org/11229015/diff/1/chrome/browser/sync/invalidati...
chrome/browser/sync/invalidations/invalidator_storage_unittest.cc:20: bool
operator==(const InvalidationState& lhs, const InvalidationState& rhs) {
On 2012/10/19 21:21:26, akalin wrote:
> yeah, i don't quite like this.  but it's yet another yak to shave -- maybe add
a
> TODO to replace with Equals?

Eventually I'd like to write a template helper for this. We already have a lot
of things that compare maps where we need to use Equals() for the value, and it
seems silly to keep copying and pasting that code.

Powered by Google App Engine
This is Rietveld 408576698