[NaCl SDK] Refactor sdk_update*.

native_client_sdk/src/build_tools/tests/test_sdktools.py

Index: native_client_sdk/src/build_tools/tests/test_sdktools.py
diff --git a/native_client_sdk/src/build_tools/tests/test_sdktools.py b/native_client_sdk/src/build_tools/tests/test_sdktools.py
index c453f240d384d652ec5465c022c3335d1eda900e..e6d25e7e40769f4a56b31fedc85afba0ed1d5771 100755
--- a/native_client_sdk/src/build_tools/tests/test_sdktools.py
+++ b/native_client_sdk/src/build_tools/tests/test_sdktools.py
@@ -112,15 +112,16 @@ class SdkToolsTestCase(unittest.TestCase):
     naclsdk_shell_script = os.path.join(self.basedir, 'nacl_sdk', 'naclsdk')
     if getos.GetPlatform() == 'win':
       naclsdk_shell_script += '.bat'
-    cmd = [naclsdk_shell_script, '-U', self.server.GetURL(MANIFEST_BASENAME)]
+    cmd = [naclsdk_shell_script]
     cmd.extend(args)
+    cmd.extend(['-U', self.server.GetURL(MANIFEST_BASENAME)])

[Sam Clegg, 2012/10/22 22:55:30]

So does '-U' first no longer work? 

[binji, 2012/10/23 00:14:09]

No, it is a breaking change. But in some ways I think it is clearer than having
a separate set of options for the "naclsdk" and the command that it runs.

     process = subprocess.Popen(cmd, stdout=subprocess.PIPE)
     stdout, _ = process.communicate()
     self.assertEqual(process.returncode, 0)
     return stdout
-  
+
   def _RunAndExtractRevision(self):
-    stdout = self._Run(['-v'])
+    stdout = self._Run(['version'])
     match = re.search('version r(\d+)', stdout)
     self.assertTrue(match is not None)
     return int(match.group(1))
@@ -211,10 +212,7 @@ class TestAutoUpdateSdkToolsDifferentFilesystem(TestAutoUpdateSdkTools):
 
 
 def main():
-  suite = unittest.defaultTestLoader.loadTestsFromModule(sys.modules[__name__])
-  result = unittest.TextTestRunner(verbosity=2).run(suite)
-
-  return int(not result.wasSuccessful())
+  unittest.main()
 
 if __name__ == '__main__':
   sys.exit(main())