native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README - Issue 11228013: [NaCl SDK] Refactor sdk_update*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README

Issue 11228013: [NaCl SDK] Refactor sdk_update*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests pass Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py ('K') | « native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py ('k') | native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/__init__.py » ('j') | native_client_sdk/src/build_tools/tests/test_sdktools.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README

diff --git a/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README b/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README

index 91da20ec7d975e9024b99b26772d9b4a6010cdc4..bec8c97698d736bcbf099f5bd467053ca29ff0ac 100644

--- a/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README

+++ b/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README

@@ -19,3 +19,19 @@ distributed under the License is distributed on an "AS IS" BASIS,

WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

See the License for the specific language governing permissions and

limitations under the License.

+======================

+Diff:

+--- a/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/__init__.py

++++ b/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/__init__.py

+@@ -22,6 +22,13 @@ from urllib import splittype

+ from urllib import splituser

+ from urllib import splitpasswd

++# W0612: Unused variable

++# W0212: Access to a protected member of a client class

++# W0622: Redefining built-in 'type'

++# W0232: Class has no __init__ method

++# pylint: disable=W0612,W0212,W0622,W0232

Sam Clegg 2012/10/22 22:55:30 Maybe better just to add "sdk_tools/third_party" t

binji 2012/10/23 00:14:09 Done.