chrome/common/extensions/extension_l10n_util.cc - Issue 1120006: detect preferences errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_l10n_util.cc

Issue 1120006: detect preferences errors (Closed)

Patch Set: changes from review Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_l10n_util.cc

diff --git a/chrome/common/extensions/extension_l10n_util.cc b/chrome/common/extensions/extension_l10n_util.cc

index cd6ad602d9130f94715590f4d1f02daa973a2745..a52d4cc8576b9d9cfde6f2752c8d0ce413bb26c5 100644

--- a/chrome/common/extensions/extension_l10n_util.cc

+++ b/chrome/common/extensions/extension_l10n_util.cc

@@ -250,7 +250,7 @@ static DictionaryValue* LoadMessageFile(const FilePath& locale_path,

FilePath file = locale_path.AppendASCII(extension_locale)

.Append(Extension::kMessagesFilename);

JSONFileValueSerializer messages_serializer(file);

- Value *dictionary = messages_serializer.Deserialize(error);

+ Value *dictionary = messages_serializer.Deserialize(NULL, error);

if (!dictionary && error->empty()) {

// JSONFileValueSerializer just returns NULL if file cannot be found. It

// doesn't set the error, so we have to do it.